Add role info command#441
Merged
Merged
Conversation
sco1
suggested changes
Sep 24, 2019
Contributor
There was a problem hiding this comment.
This works fine for exact input(s), but I think the Greedy operator is more harmful than helpful here.
Along with being case-sensitive, it also partially surpresses some of the feedback from invalid parameters and stops parsing if an invalid role is found. I think the desired behavior could be accomplished with something along the lines of *roles: Union[Role, str] and a helper fallback converter (or just a custom converter) for roles that can't be converted.
sco1
approved these changes
Oct 1, 2019
GhostofGoes
approved these changes
Oct 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new command to show specific info (colour, id, permissions, position) about a list of given roles.
Closes #440.